Support include query parameter for list roles #1228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
|
Hey @Fabian-K , thanks for your contribution! Could you please:
|
Fabian-K
force-pushed
the
feature/role-include
branch
2 times, most recently
from
39c1ca6 to
49427f3
Compare
|
@Kehrlann Thanks for picking this up! I´ve rebased and added an integration test. I did however not run the integration test because I don´t have a cf landscape available with admin permissions. I only used a local build of the client and was able to do some testing there. |
|
@Fabian-K Thanks! Will run the integration tests and let you know. Please apply the formatting rules on the integration test project as well:
|
Fabian-K
force-pushed
the
feature/role-include
branch
from
49427f3 to
eecd9d2
Compare
|
Done, thank you! |
Kehrlann
requested changes
Jun 18, 2025
cloudfoundry-client/src/main/java/org/cloudfoundry/client/v3/users/User.java
Show resolved
Hide resolved
Fabian-K
force-pushed
the
feature/role-include
branch
from
eecd9d2 to
dba4242
Compare
|
@Fabian-K this is in backlog, but we're in the middle of infrastructure migration, so I don't have an env at the moment. I'll merge this when I can test it. |
|
@Fabian-K I finally got a chance to run the integration test. Unfortunately, it does not work, and fails with: That's because the response to the roles request looks like this: {
"pagination": {
"total_results": 1,
"total_pages": 1,
"first": {
"href": "https://api.sys.tas.7f364f3c.shepherd.tanzu.broadcom.net/v3/roles?guids=d5cae192-3d32-4be2-b786-4bf07600d06b&include=user&order_by=%2Bcreated_at&page=1&per_page=50"
},
"last": {
"href": "https://api.sys.tas.7f364f3c.shepherd.tanzu.broadcom.net/v3/roles?guids=d5cae192-3d32-4be2-b786-4bf07600d06b&include=user&order_by=%2Bcreated_at&page=1&per_page=50"
},
"next": null,
"previous": null
},
"resources": [
{
"guid": "d5cae192-3d32-4be2-b786-4bf07600d06b",
"created_at": "2025-07-10T08:41:01Z",
"updated_at": "2025-07-10T08:41:01Z",
"type": "organization_user",
"relationships": {
"user": {
"data": {
"guid": "test-user-id-b99k7"
}
},
"organization": {
"data": {
"guid": "56e6381d-7219-451d-ab4b-10576d49a0ac"
}
},
"space": {
"data": null
}
},
"links": {
"self": {
"href": "https://api.sys.tas.7f364f3c.shepherd.tanzu.broadcom.net/v3/roles/d5cae192-3d32-4be2-b786-4bf07600d06b"
},
"user": {
"href": "https://api.sys.tas.7f364f3c.shepherd.tanzu.broadcom.net/v3/users/test-user-id-b99k7"
},
"organization": {
"href": "https://api.sys.tas.7f364f3c.shepherd.tanzu.broadcom.net/v3/organizations/56e6381d-7219-451d-ab4b-10576d49a0ac"
}
}
}
],
"included": {
"users": [
{
"guid": "test-user-id-b99k7",
"created_at": "2025-07-10T08:41:01Z",
"updated_at": "2025-07-10T08:41:01Z",
"username": null,
"presentation_name": "test-user-id-b99k7",
"origin": null,
"metadata": {
"labels": {},
"annotations": {}
},
"links": {
"self": {
"href": "https://api.sys.tas.7f364f3c.shepherd.tanzu.broadcom.net/v3/users/test-user-id-b99k7"
}
}
}
]
}
}And, AFAICT, this is not a valid |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
this PR adds support for the "include" query parameter to the list roles request API v3. This is my first contribution to this repository. Please let me know in case I missed something :)
Thanks,
Fabian
fixes #1204